Repository navigation
feat(support flush coins): support flushing native ETH coin - #985
Merged
Merged
Conversation
glowang
force-pushed
the
BG-28129-support-flush-coins
branch
from
January 12, 2021 17:38
3345bf0 to
2afcddf
Compare
Codecov Report
@@ Coverage Diff @@
## master #985 +/- ##
==========================================
+ Coverage 57.93% 64.83% +6.90%
==========================================
Files 109 183 +74
Lines 10340 13400 +3060
Branches 1985 2466 +481
==========================================
+ Hits 5990 8688 +2698
- Misses 3541 3746 +205
- Partials 809 966 +157
Flags with carried forward coverage won't be shown. Click here to find out more.
|
marktoda
reviewed
Jan 14, 2021
Contributor
|
next time, please avoid adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, clients might send ETH to an address before the wallet deployment tx has been confirmed due to fee spike, which results in ETH stuck in forwarders that need to be flushed.
This PR adds a transaction type to the ETH transaction builder. This allows us to build flush tx in Wallet Platform later.